From 1aa4ae7752bdfac9577690df072a07cb9c615b98 Mon Sep 17 00:00:00 2001 From: vchikalkin Date: Wed, 12 Apr 2023 00:37:12 +0300 Subject: [PATCH] Revert "tools: fix disposableReaction function" This reverts commit 627b97413fbba8f6ac86c75ecce72b106d9bc0b2. --- packages/tools/mobx.ts | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/packages/tools/mobx.ts b/packages/tools/mobx.ts index a24bc94..c4c2b90 100644 --- a/packages/tools/mobx.ts +++ b/packages/tools/mobx.ts @@ -1,6 +1,6 @@ import type { IReactionDisposer, IReactionOptions, IReactionPublic } from 'mobx'; import { autorun, reaction } from 'mobx'; -import { debounce } from 'radash'; +import { debounce, omit } from 'radash'; export function disposableReaction( mustBeDisposed: () => boolean, @@ -14,6 +14,10 @@ export function disposableReaction( ) { let disposer: IReactionDisposer | undefined; + if (!mustBeDisposed()) { + disposer = reaction(expression, effect, reactionOpts); + } + function cleanDisposer() { disposer = undefined; } @@ -23,7 +27,8 @@ export function disposableReaction( if (disposer !== undefined) disposer(); cleanDisposer(); } else { - disposer = reaction(expression, effect, reactionOpts); + const opts = reactionOpts ? omit(reactionOpts, ['fireImmediately']) : undefined; + disposer = reaction(expression, effect, opts); } }); }