From b6f22d79400f5b39b1a494e25978c9179e4b1499 Mon Sep 17 00:00:00 2001 From: vchikalkin Date: Mon, 13 Mar 2023 11:27:09 +0300 Subject: [PATCH] eslint: warn some rules --- apps/web/process/add-product/reactions.ts | 1 - apps/web/process/bonuses/lib/helper.ts | 1 - apps/web/process/bonuses/reactions/common.ts | 1 - apps/web/process/calculate/reactions/common.ts | 1 - apps/web/process/configurator/reactions/filters.ts | 1 - apps/web/process/configurator/reactions/values.ts | 1 - apps/web/process/configurator/validation.ts | 1 - apps/web/process/fingap/reactions/common.ts | 1 - apps/web/process/gibdd/get-kp-data.ts | 1 - apps/web/process/gibdd/lib/helper.ts | 1 - apps/web/process/gibdd/reactions.ts | 1 - apps/web/process/gibdd/validation.ts | 1 - apps/web/process/init/get-initial-data.ts | 1 - apps/web/process/insurance/reactions.ts | 1 - apps/web/process/leasing-object/get-kp-data.ts | 1 - apps/web/process/leasing-object/reactions/common.ts | 1 - apps/web/process/leasing-object/reactions/validation.ts | 1 - apps/web/process/leasing-object/validation.ts | 1 - apps/web/process/leasing-without-kasko/reactions.ts | 2 +- apps/web/process/price/reactions/common.ts | 1 - apps/web/process/price/reactions/computed.ts | 1 - apps/web/process/price/reactions/validation.ts | 1 - apps/web/process/price/validation.ts | 1 - apps/web/process/subsidy-import-program/reactions.ts | 2 +- apps/web/process/supplier-agent/get-kp-data/get-sums.ts | 1 - apps/web/process/supplier-agent/lib/create-reactions.ts | 1 - apps/web/process/supplier-agent/reactions/agents.ts | 1 - apps/web/process/supplier-agent/validation.ts | 2 -- apps/web/process/used-pl/reactions.ts | 1 - apps/web/process/used-pl/validation.ts | 1 - packages/eslint-config-custom/rules.js | 8 ++++++++ 31 files changed, 10 insertions(+), 31 deletions(-) diff --git a/apps/web/process/add-product/reactions.ts b/apps/web/process/add-product/reactions.ts index 6930279..3963bb4 100644 --- a/apps/web/process/add-product/reactions.ts +++ b/apps/web/process/add-product/reactions.ts @@ -1,4 +1,3 @@ -/* eslint-disable @typescript-eslint/naming-convention */ import type { ProcessContext } from '../types'; import * as CRMTypes from '@/graphql/crm.types'; import dayjs from 'dayjs'; diff --git a/apps/web/process/bonuses/lib/helper.ts b/apps/web/process/bonuses/lib/helper.ts index 8273620..0077d02 100644 --- a/apps/web/process/bonuses/lib/helper.ts +++ b/apps/web/process/bonuses/lib/helper.ts @@ -1,4 +1,3 @@ -/* eslint-disable @typescript-eslint/naming-convention */ import type { ValidationContext } from '../../types'; import { getUser } from '@/api/user/query'; import type { ElementsTypes } from '@/Components/Calculation/config/map/values'; diff --git a/apps/web/process/bonuses/reactions/common.ts b/apps/web/process/bonuses/reactions/common.ts index 27160b8..b8af8b5 100644 --- a/apps/web/process/bonuses/reactions/common.ts +++ b/apps/web/process/bonuses/reactions/common.ts @@ -1,4 +1,3 @@ -/* eslint-disable @typescript-eslint/naming-convention */ import type { ProcessContext } from '../../types'; import helper from '../lib/helper'; import * as CRMTypes from '@/graphql/crm.types'; diff --git a/apps/web/process/calculate/reactions/common.ts b/apps/web/process/calculate/reactions/common.ts index aa940f3..dcc81ac 100644 --- a/apps/web/process/calculate/reactions/common.ts +++ b/apps/web/process/calculate/reactions/common.ts @@ -1,4 +1,3 @@ -/* eslint-disable @typescript-eslint/naming-convention */ import * as CRMTypes from '@/graphql/crm.types'; import type { ProcessContext } from '@/process/types'; import { reaction } from 'mobx'; diff --git a/apps/web/process/configurator/reactions/filters.ts b/apps/web/process/configurator/reactions/filters.ts index b200309..8434497 100644 --- a/apps/web/process/configurator/reactions/filters.ts +++ b/apps/web/process/configurator/reactions/filters.ts @@ -1,4 +1,3 @@ -/* eslint-disable @typescript-eslint/naming-convention */ import { radioCalcType, radioGraphType, selectSeasonType } from '@/config/default-options'; import * as CRMTypes from '@/graphql/crm.types'; import { SEASON_TYPES } from '@/process/payments/lib/seasons-constants'; diff --git a/apps/web/process/configurator/reactions/values.ts b/apps/web/process/configurator/reactions/values.ts index 463e698..47dc84b 100644 --- a/apps/web/process/configurator/reactions/values.ts +++ b/apps/web/process/configurator/reactions/values.ts @@ -1,4 +1,3 @@ -/* eslint-disable @typescript-eslint/naming-convention */ import type { Elements } from '@/Components/Calculation/config/map/values'; import * as CRMTypes from '@/graphql/crm.types'; import type { ProcessContext } from '@/process/types'; diff --git a/apps/web/process/configurator/validation.ts b/apps/web/process/configurator/validation.ts index c25abc4..c24707e 100644 --- a/apps/web/process/configurator/validation.ts +++ b/apps/web/process/configurator/validation.ts @@ -1,4 +1,3 @@ -/* eslint-disable @typescript-eslint/naming-convention */ import type { ValidationContext } from '../types'; import ValuesSchema from '@/config/schema/values'; import * as CRMTypes from '@/graphql/crm.types'; diff --git a/apps/web/process/fingap/reactions/common.ts b/apps/web/process/fingap/reactions/common.ts index 2d43f07..1b18a00 100644 --- a/apps/web/process/fingap/reactions/common.ts +++ b/apps/web/process/fingap/reactions/common.ts @@ -1,4 +1,3 @@ -/* eslint-disable @typescript-eslint/naming-convention */ import { calculateFinGAP } from '@/api/core/query'; import type { RequestFinGAP } from '@/api/core/types'; import type { Risk } from '@/Components/Calculation/Form/Insurance/FinGAPTable/types'; diff --git a/apps/web/process/gibdd/get-kp-data.ts b/apps/web/process/gibdd/get-kp-data.ts index 60e9ccf..df0e226 100644 --- a/apps/web/process/gibdd/get-kp-data.ts +++ b/apps/web/process/gibdd/get-kp-data.ts @@ -1,4 +1,3 @@ -/* eslint-disable @typescript-eslint/naming-convention */ import type { GetQuoteInputData, GetQuoteProcessData } from '../load-kp/types'; import helper from './lib/helper'; import initializeApollo from '@/apollo/client'; diff --git a/apps/web/process/gibdd/lib/helper.ts b/apps/web/process/gibdd/lib/helper.ts index 5a5eae9..68a7c4a 100644 --- a/apps/web/process/gibdd/lib/helper.ts +++ b/apps/web/process/gibdd/lib/helper.ts @@ -1,4 +1,3 @@ -/* eslint-disable @typescript-eslint/naming-convention */ import * as CRMTypes from '@/graphql/crm.types'; import type { ProcessContext } from '@/process/types'; import type { CalculationValues } from '@/stores/calculation/values/types'; diff --git a/apps/web/process/gibdd/reactions.ts b/apps/web/process/gibdd/reactions.ts index a2f65ed..701f66a 100644 --- a/apps/web/process/gibdd/reactions.ts +++ b/apps/web/process/gibdd/reactions.ts @@ -1,4 +1,3 @@ -/* eslint-disable @typescript-eslint/naming-convention */ import type { ProcessContext } from '../types'; import helper from './lib/helper'; import { createValidationSchema } from './validation'; diff --git a/apps/web/process/gibdd/validation.ts b/apps/web/process/gibdd/validation.ts index e1c90c6..b1fb526 100644 --- a/apps/web/process/gibdd/validation.ts +++ b/apps/web/process/gibdd/validation.ts @@ -1,4 +1,3 @@ -/* eslint-disable @typescript-eslint/naming-convention */ import type { ValidationContext } from '../types'; import ValuesSchema from '@/config/schema/values'; import { MAX_MASS } from '@/constants/values'; diff --git a/apps/web/process/init/get-initial-data.ts b/apps/web/process/init/get-initial-data.ts index b585d3d..d97a2bf 100644 --- a/apps/web/process/init/get-initial-data.ts +++ b/apps/web/process/init/get-initial-data.ts @@ -1,4 +1,3 @@ -/* eslint-disable @typescript-eslint/naming-convention */ import type { User } from '@/api/user/types'; import * as CRMTypes from '@/graphql/crm.types'; import type { ApolloClient } from '@apollo/client'; diff --git a/apps/web/process/insurance/reactions.ts b/apps/web/process/insurance/reactions.ts index 4b189f9..b895532 100644 --- a/apps/web/process/insurance/reactions.ts +++ b/apps/web/process/insurance/reactions.ts @@ -1,4 +1,3 @@ -/* eslint-disable @typescript-eslint/naming-convention */ import type { ProcessContext } from '../types'; import { createValidationSchema } from './validation'; import type { Elements } from '@/Components/Calculation/config/map/values'; diff --git a/apps/web/process/leasing-object/get-kp-data.ts b/apps/web/process/leasing-object/get-kp-data.ts index d6f1db9..74867d0 100644 --- a/apps/web/process/leasing-object/get-kp-data.ts +++ b/apps/web/process/leasing-object/get-kp-data.ts @@ -1,4 +1,3 @@ -/* eslint-disable @typescript-eslint/naming-convention */ import type { GetQuoteInputData, GetQuoteProcessData } from '../load-kp/types'; import initializeApollo from '@/apollo/client'; import defaultValues from '@/config/default-values'; diff --git a/apps/web/process/leasing-object/reactions/common.ts b/apps/web/process/leasing-object/reactions/common.ts index 0842641..c51518c 100644 --- a/apps/web/process/leasing-object/reactions/common.ts +++ b/apps/web/process/leasing-object/reactions/common.ts @@ -1,4 +1,3 @@ -/* eslint-disable @typescript-eslint/naming-convention */ import * as CRMTypes from '@/graphql/crm.types'; import type { ProcessContext } from '@/process/types'; import { reaction } from 'mobx'; diff --git a/apps/web/process/leasing-object/reactions/validation.ts b/apps/web/process/leasing-object/reactions/validation.ts index 417ff38..d83b8db 100644 --- a/apps/web/process/leasing-object/reactions/validation.ts +++ b/apps/web/process/leasing-object/reactions/validation.ts @@ -1,4 +1,3 @@ -/* eslint-disable @typescript-eslint/naming-convention */ import { createValidationSchema } from '../validation'; import type { Elements } from '@/Components/Calculation/config/map/values'; import type { ProcessContext } from '@/process/types'; diff --git a/apps/web/process/leasing-object/validation.ts b/apps/web/process/leasing-object/validation.ts index 72d4437..28430c4 100644 --- a/apps/web/process/leasing-object/validation.ts +++ b/apps/web/process/leasing-object/validation.ts @@ -1,4 +1,3 @@ -/* eslint-disable @typescript-eslint/naming-convention */ import type { ValidationContext } from '../types'; import ValuesSchema from '@/config/schema/values'; import * as CRMTypes from '@/graphql/crm.types'; diff --git a/apps/web/process/leasing-without-kasko/reactions.ts b/apps/web/process/leasing-without-kasko/reactions.ts index ef9cc5a..fbe7912 100644 --- a/apps/web/process/leasing-without-kasko/reactions.ts +++ b/apps/web/process/leasing-without-kasko/reactions.ts @@ -1,5 +1,5 @@ /* eslint-disable canonical/sort-keys */ -/* eslint-disable @typescript-eslint/naming-convention */ + import * as CRMTypes from '@/graphql/crm.types'; import type { ProcessContext } from '@/process/types'; import dayjs from 'dayjs'; diff --git a/apps/web/process/price/reactions/common.ts b/apps/web/process/price/reactions/common.ts index a227432..d393e3b 100644 --- a/apps/web/process/price/reactions/common.ts +++ b/apps/web/process/price/reactions/common.ts @@ -1,4 +1,3 @@ -/* eslint-disable @typescript-eslint/naming-convention */ import { VAT } from '@/constants/values'; import * as CRMTypes from '@/graphql/crm.types'; import type { ProcessContext } from '@/process/types'; diff --git a/apps/web/process/price/reactions/computed.ts b/apps/web/process/price/reactions/computed.ts index af76d14..8ec3b9b 100644 --- a/apps/web/process/price/reactions/computed.ts +++ b/apps/web/process/price/reactions/computed.ts @@ -1,4 +1,3 @@ -/* eslint-disable @typescript-eslint/naming-convention */ import * as CRMTypes from '@/graphql/crm.types'; import type { ProcessContext } from '@/process/types'; import dayjs from 'dayjs'; diff --git a/apps/web/process/price/reactions/validation.ts b/apps/web/process/price/reactions/validation.ts index 32343d9..236a9c5 100644 --- a/apps/web/process/price/reactions/validation.ts +++ b/apps/web/process/price/reactions/validation.ts @@ -1,4 +1,3 @@ -/* eslint-disable @typescript-eslint/naming-convention */ import { createValidationSchema } from '../validation'; import type { Elements } from '@/Components/Calculation/config/map/values'; import type { ProcessContext } from '@/process/types'; diff --git a/apps/web/process/price/validation.ts b/apps/web/process/price/validation.ts index 427a09e..a924ba2 100644 --- a/apps/web/process/price/validation.ts +++ b/apps/web/process/price/validation.ts @@ -1,4 +1,3 @@ -/* eslint-disable @typescript-eslint/naming-convention */ import type { ValidationContext } from '../types'; import ValuesSchema from '@/config/schema/values'; import { VAT } from '@/constants/values'; diff --git a/apps/web/process/subsidy-import-program/reactions.ts b/apps/web/process/subsidy-import-program/reactions.ts index 40af966..a834ce9 100644 --- a/apps/web/process/subsidy-import-program/reactions.ts +++ b/apps/web/process/subsidy-import-program/reactions.ts @@ -1,5 +1,5 @@ /* eslint-disable no-negated-condition */ -/* eslint-disable @typescript-eslint/naming-convention */ + import type { ProcessContext } from '../types'; import * as CRMTypes from '@/graphql/crm.types'; import { reaction } from 'mobx'; diff --git a/apps/web/process/supplier-agent/get-kp-data/get-sums.ts b/apps/web/process/supplier-agent/get-kp-data/get-sums.ts index d12138e..299fcb5 100644 --- a/apps/web/process/supplier-agent/get-kp-data/get-sums.ts +++ b/apps/web/process/supplier-agent/get-kp-data/get-sums.ts @@ -1,4 +1,3 @@ -/* eslint-disable @typescript-eslint/naming-convention */ import initializeApollo from '@/apollo/client'; import type * as CRMTypes from '@/graphql/crm.types'; import { gql } from '@apollo/client'; diff --git a/apps/web/process/supplier-agent/lib/create-reactions.ts b/apps/web/process/supplier-agent/lib/create-reactions.ts index 5108e68..a0a38ed 100644 --- a/apps/web/process/supplier-agent/lib/create-reactions.ts +++ b/apps/web/process/supplier-agent/lib/create-reactions.ts @@ -1,4 +1,3 @@ -/* eslint-disable @typescript-eslint/naming-convention */ import type { AgentsFields, AgentsRewardConditionsFields, AgentsSumFields } from './types'; import * as CRMTypes from '@/graphql/crm.types'; import type RootStore from '@/stores/root'; diff --git a/apps/web/process/supplier-agent/reactions/agents.ts b/apps/web/process/supplier-agent/reactions/agents.ts index c4e94be..866de94 100644 --- a/apps/web/process/supplier-agent/reactions/agents.ts +++ b/apps/web/process/supplier-agent/reactions/agents.ts @@ -1,4 +1,3 @@ -/* eslint-disable @typescript-eslint/naming-convention */ /* eslint-disable sonarjs/no-identical-functions */ import * as createReactions from '../lib/create-reactions'; import * as fillAgentsFromLead from '../lib/fill-agents-from-lead'; diff --git a/apps/web/process/supplier-agent/validation.ts b/apps/web/process/supplier-agent/validation.ts index 47a2a4b..63baed2 100644 --- a/apps/web/process/supplier-agent/validation.ts +++ b/apps/web/process/supplier-agent/validation.ts @@ -1,5 +1,3 @@ -/* eslint-disable zod/require-strict */ -/* eslint-disable @typescript-eslint/naming-convention */ /* eslint-disable complexity */ import type { ValidationContext } from '../types'; import type { Elements } from '@/Components/Calculation/config/map/values'; diff --git a/apps/web/process/used-pl/reactions.ts b/apps/web/process/used-pl/reactions.ts index 8375a75..3d38931 100644 --- a/apps/web/process/used-pl/reactions.ts +++ b/apps/web/process/used-pl/reactions.ts @@ -1,4 +1,3 @@ -/* eslint-disable @typescript-eslint/naming-convention */ import type { ProcessContext } from '../types'; import { createValidationSchema } from './validation'; import type { Elements } from '@/Components/Calculation/config/map/values'; diff --git a/apps/web/process/used-pl/validation.ts b/apps/web/process/used-pl/validation.ts index b759cbd..a926499 100644 --- a/apps/web/process/used-pl/validation.ts +++ b/apps/web/process/used-pl/validation.ts @@ -1,4 +1,3 @@ -/* eslint-disable @typescript-eslint/naming-convention */ import type { ValidationContext } from '../types'; import ValuesSchema from '@/config/schema/values'; import * as CRMTypes from '@/graphql/crm.types'; diff --git a/packages/eslint-config-custom/rules.js b/packages/eslint-config-custom/rules.js index 091a394..ea04884 100644 --- a/packages/eslint-config-custom/rules.js +++ b/packages/eslint-config-custom/rules.js @@ -55,6 +55,7 @@ module.exports = { 'import/no-unassigned-import': 'off', 'import/no-named-as-default-member': 'warn', 'react/jsx-sort-props': 'off', + '@typescript-eslint/naming-convention': 'warn', // Unicorn 'unicorn/no-array-for-each': 'off', @@ -130,6 +131,13 @@ module.exports = { requireReturnForObjectLiteral: false, }, ], + + // Sonar + 'sonarjs/no-duplicate-string': 'warn', + + // Zod + 'zod/require-strict': 'off', + // Turbo 'turbo/no-undeclared-env-vars': 'warn', },